Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes tekton tab #749

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: removes tekton tab #749

merged 1 commit into from
Nov 9, 2023

Conversation

invincibleJai
Copy link
Member

Description

The dedicated tekon tab is no longer needed as it will only be shown on the CI tab

Which issue(s) does this PR fix

Screenshots

image

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@invincibleJai invincibleJai requested a review from a team as a code owner November 9, 2023 15:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 905b5e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

tumido
tumido approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido added the cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch label Nov 9, 2023
Zaperex
Zaperex approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schultzp2020
schultzp2020 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schultzp2020 schultzp2020 merged commit f69c4d0 into janus-idp:main Nov 9, 2023
6 checks passed
schultzp2020 pushed a commit that referenced this pull request Nov 9, 2023
@invincibleJai @schultzp2020
fix: removes tekton tab (#749)
9113665
@schultzp2020
Copy link
Member

PR has been cherry-picked

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

The image is available at: quay.io/janus-idp/backstage-showcase:pr-749!

@kadel kadel added the cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch. label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schultzp2020 schultzp2020 schultzp2020 approved these changes

@Zaperex Zaperex Zaperex approved these changes

@tumido tumido tumido approved these changes

Assignees
No one assigned
Labels
cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tekton plugin should be shown only on CI tab and not dedicated Tekton tab
5 participants
@invincibleJai @schultzp2020 @tumido @Zaperex @kadel