Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: verify TLS config with Postgres in Amazon RDS using Helm #1798

Merged
merged 4 commits into from
Nov 14, 2024
Merged

test: verify TLS config with Postgres in Amazon RDS using Helm #1798

merged 4 commits into from
Nov 14, 2024

Conversation

Omar-AlJaljuli
Copy link
Contributor

Description

[Test Automation] Verify TLS config with Postgres in Amazon RDS using Helm

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-2915

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Omar-AlJaljuli Omar-AlJaljuli requested a review from a team as a code owner October 21, 2024 15:33
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

3 similar comments
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

3 similar comments
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@Omar-AlJaljuli
Copy link
Contributor Author

/retest

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1798!

@Omar-AlJaljuli
Copy link
Contributor Author

Omar-AlJaljuli commented Oct 25, 2024 •
edited
Loading

image
Changes were tested with PR check, but aren't part of the PR check now as they are meant only for nightly jobs.

@Omar-AlJaljuli Omar-AlJaljuli changed the title [WIP] [Test Automation] Verify TLS config with Postgres in Amazon RDS using Helm [Test Automation] Verify TLS config with Postgres in Amazon RDS using Helm Oct 25, 2024
@Omar-AlJaljuli Omar-AlJaljuli changed the title [Test Automation] Verify TLS config with Postgres in Amazon RDS using Helm test: Verify TLS config with Postgres in Amazon RDS using Helm Oct 25, 2024
@Omar-AlJaljuli Omar-AlJaljuli changed the title test: Verify TLS config with Postgres in Amazon RDS using Helm test: verify TLS config with Postgres in Amazon RDS using Helm Oct 25, 2024
@Omar-AlJaljuli
Copy link
Contributor Author

/retest

1 similar comment
@Omar-AlJaljuli
Copy link
Contributor Author

/retest

@Omar-AlJaljuli
Copy link
Contributor Author

/test e2e-tests

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@Omar-AlJaljuli
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Nov 13, 2024
@Omar-AlJaljuli
TLS config with RDS tested with a healthy check
10379e3 
This tests successful rhdh plugin initialization

readding main deployment

ignore the the TLS check in other tests

consider rds values rename

make all secrets base64 before applying

add rhdh-dyanmic-plugins-root

add path for postgres-crt
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@zdrapela
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2024
@josephca
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca, zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@josephca josephca merged commit a1b82a9 into janus-idp:main Nov 14, 2024
9 of 11 checks passed
@josephca
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavolira gustavolira gustavolira left review comments

@zdrapela zdrapela zdrapela approved these changes

@josephca josephca josephca approved these changes

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

Assignees

@josephca josephca

@zdrapela zdrapela

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Omar-AlJaljuli @josephca @zdrapela @gustavolira @openshift-merge-robot