Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.3] fix: update janus-idp/cli in wrappers to 1.13.3 #1814

Merged
merged 4 commits into from
Nov 5, 2024
Merged

[release-1.3] fix: update janus-idp/cli in wrappers to 1.13.3 #1814

merged 4 commits into from
Nov 5, 2024

Conversation

kadel
Copy link
Member

@kadel kadel commented Oct 23, 2024

Description

Update janus-idp/cli in wrappers to the 1.13.3 that include fix for https://issues.redhat.com/browse/RHIDP-3574

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kadel kadel requested a review from a team as a code owner October 23, 2024 15:53
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

@kadel
Copy link
Member Author

kadel commented Oct 29, 2024

/retest

1 similar comment
@kadel
Copy link
Member Author

kadel commented Oct 29, 2024

/retest

@kadel kadel force-pushed the release-1.3-update-junus-idp-cli branch 2 times, most recently from dfaa22f to ff9439f Compare October 30, 2024 08:38
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

@kadel
Copy link
Member Author

kadel commented Nov 4, 2024

/retest

2 similar comments
@kadel
Copy link
Member Author

kadel commented Nov 4, 2024

/retest

@kadel
Copy link
Member Author

kadel commented Nov 4, 2024

/retest

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

@kadel
Copy link
Member Author

kadel commented Nov 5, 2024

/retest

@kadel kadel force-pushed the release-1.3-update-junus-idp-cli branch from 238a7bd to 949d96e Compare November 5, 2024 10:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

@nickboldt nickboldt self-requested a review November 5, 2024 18:46
@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@nickboldt
also update app to use latest cli
93ffd8c 
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt
remove dep on @janus-idp/cli@1.13.2 from yarn lock
4752c91 
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Nov 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 5, 2024

New changes are detected. LGTM label has been removed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nickboldt nickboldt enabled auto-merge (squash) November 5, 2024 18:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1814!

@nickboldt nickboldt merged commit 23c2e58 into janus-idp:release-1.3 Nov 5, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@04kash 04kash Awaiting requested review from 04kash

@dzemanov dzemanov Awaiting requested review from dzemanov

@schultzp2020 schultzp2020 Awaiting requested review from schultzp2020

Assignees

@nickboldt nickboldt

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kadel @nickboldt @schultzp2020