Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): update rbac-backend #1822

Merged
merged 3 commits into from
Nov 6, 2024
Merged

chore(release): update rbac-backend #1822

merged 3 commits into from
Nov 6, 2024

Conversation

AndrienkoAleksandr
Copy link
Contributor

Description

Update rbac-backend to the version 4.10.7

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@AndrienkoAleksandr
chore(release): update rbac-backend
ff2dad1 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr requested a review from a team as a code owner October 24, 2024 09:21
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1822!

@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@dzemanov
Copy link
Member

Works correctly 🧙‍♂️

@PatAKnight
Copy link
Member

/retest

@PatAKnight
Copy link
Member

/test e2e-tests

@PatAKnight
Copy link
Member

/retest

2 similar comments
@PatAKnight
Copy link
Member

/retest

@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@PatAKnight
Copy link
Member

/test e2e-tests

@PatAKnight
Copy link
Member

/retest

@PatAKnight
Copy link
Member

/test e2e-tests

@christoph-jerolimov
Copy link
Member

The image was broken, @ciiay fixed an issue with #1847, let see if this helps

/retest

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1822!

@PatAKnight
Copy link
Member

/test e2e-tests

2 similar comments
@PatAKnight
Copy link
Member

/test e2e-tests

@PatAKnight
Copy link
Member

/test e2e-tests

@josephca
Copy link
Member

josephca commented Nov 5, 2024

/test e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Nov 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1822!

@PatAKnight
Copy link
Member

/retest

nickboldt
nickboldt approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit ad2e8eb into janus-idp:release-1.3 Nov 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@Fortune-Ndlovu Fortune-Ndlovu Awaiting requested review from Fortune-Ndlovu

@JessicaJHee JessicaJHee Awaiting requested review from JessicaJHee

Assignees

@nickboldt nickboldt

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndrienkoAleksandr @dzemanov @PatAKnight @christoph-jerolimov @josephca @nickboldt