Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade argocd plugin to fix a CVE [release-1.3] #1835

Merged

Conversation

karthikjeeyar
Copy link
Contributor

Description

Upgrading to argocd 1.8.10 to include CVE fix - CVE-2024-21534

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@karthikjeeyar karthikjeeyar requested a review from a team as a code owner October 29, 2024 16:38
@kim-tsao
Copy link
Member

/lgtm
/approve

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1835!

@kim-tsao
Copy link
Member

/test e2e-tests

1 similar comment
@karthikjeeyar
Copy link
Contributor Author

/test e2e-tests

@christoph-jerolimov
Copy link
Member

The image was broken, @ciiay fixed an issue with #1847, let see if this helps

/retest

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1835!

@openshift-ci openshift-ci bot removed the lgtm label Oct 31, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1835!

@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/test e2e-tests

@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2024
@nickboldt nickboldt changed the title fix(deps): upgrade argocd plugin to fix a CVE fix(deps): upgrade argocd plugin to fix a CVE [release-1.3] Nov 5, 2024
Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/test e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Nov 6, 2024
Copy link

openshift-ci bot commented Nov 6, 2024

New changes are detected. LGTM label has been removed.

Copy link

sonarcloud bot commented Nov 6, 2024

Copy link
Contributor

github-actions bot commented Nov 6, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1835!

@nickboldt nickboldt added the lgtm label Nov 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 61b04d9 into janus-idp:release-1.3 Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants