chore(e2e): rhidp-4049 change app-config at e2e test runtime #1850
Conversation
gustavolira
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gustavolira
changed the title
gustavolira
force-pushed
the
RHIDP-4049-new
branch
from
0fce778
to
cac1f2b
Compare
|
The image is available at: |
1 similar comment
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
gustavolira
force-pushed
the
RHIDP-4049-new
branch
from
fd6a03e
to
fe0e058
Compare
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Updated the yarn.lock and e2e-tests/package.json files to include js-yaml as a dependency. This change ensures that js-yaml is correctly fetched and utilized in our project. Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Unified the usage of double quotes across various files to maintain code consistency. This change affects spec files, configuration files, and utility scripts in the e2e test suite. Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Corrected a typo in the kubeClient class name and improved the initialization method by directly loading from options. Also added a new method to update the ConfigMap title dynamically using yaml parsing. Signed-off-by: Gustavo Lira <guga.java@gmail.com>
gustavolira
force-pushed
the
RHIDP-4049-new
branch
from
9a20d15
to
67f2f50
Compare
Corrected a typo in the method name from "updateCongifmap" to "updateConfigMap" and standardized string quotes to double quotes in k8sHelper.ts for consistency. This helps improve code readability and maintainability. Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Correct the spelling of the kubeClient variable to ensure proper initialization. This change addresses a typo that could potentially cause runtime errors or misbehavior in the code execution. Signed-off-by: Gustavo Lira <guga.java@gmail.com>
|
|
The image is available at: |
|
@gustavolira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer