Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor namespace deletion logic and add finalizer removal. #1866

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

gustavolira
Copy link
Contributor

@gustavolira gustavolira commented Oct 31, 2024

Refactor configure_namespace by extracting namespace deletion into a new function delete_namespace. Introduce functions to remove blocking finalizers and forcibly delete namespaces stuck in 'Terminating' status. This improves reliability and handling of namespace deletions in the OpenShift CI pipeline.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Refactor `configure_namespace` by extracting namespace deletion into a new function `delete_namespace`. Introduce functions to remove blocking finalizers and forcibly delete namespaces stuck in 'Terminating' status. This improves reliability and handling of namespace deletions in the OpenShift CI pipeline.

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
@gustavolira gustavolira requested a review from a team as a code owner October 31, 2024 17:57
Copy link

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rnapoles-rh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Oct 31, 2024

@josephca josephca removed the request for review from rnapoles-rh October 31, 2024 18:10
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1866!

Copy link

openshift-ci bot commented Oct 31, 2024

@gustavolira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 76eaae5 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josephca josephca merged commit bf9e91f into janus-idp:release-1.3 Oct 31, 2024
6 of 8 checks passed
@josephca
Copy link
Member

/lgtm
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants