Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Tekton plugin tests and comment pipeline setup steps #1876

Merged

Conversation

gustavolira
Copy link
Contributor

Temporarily disable Tekton plugin tests using test.describe.skip and comment out the steps for installing and running the pipeline in the OpenShift CI script. This change is potentially to troubleshoot or isolate issues related to the Tekton plugin or pipeline setup.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Temporarily disable Tekton plugin tests using `test.describe.skip` and comment out the steps for installing and running the pipeline in the OpenShift CI script. This change is potentially to troubleshoot or isolate issues related to the Tekton plugin or pipeline setup.

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
@gustavolira gustavolira requested a review from a team as a code owner November 4, 2024 22:01
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rnapoles-rh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Nov 4, 2024

@kim-tsao kim-tsao enabled auto-merge (squash) November 4, 2024 22:10
@kim-tsao kim-tsao merged commit f230d47 into janus-idp:release-1.3 Nov 4, 2024
5 of 8 checks passed
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1876!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants