Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update scaffolder-backend-module-regex wrapper #1908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update scaffolder-backend-module-regex wrapper #1908

wants to merge 1 commit into from
+54 −54

Conversation

04kash
Copy link
Member

@04kash 04kash commented Nov 7, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

The image is available at:

@04kash 04kash marked this pull request as ready for review November 7, 2024 22:06
@04kash 04kash requested a review from a team as a code owner November 7, 2024 22:06
@04kash 04kash requested review from nickboldt and schultzp2020 and removed request for dzemanov and its-mitesh-kumar November 7, 2024 23:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

The image is available at:

schultzp2020
schultzp2020 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

The image is available at:

@04kash 04kash force-pushed the create-wrapper-regex branch 3 times, most recently from 05b4483 to e0fc124 Compare November 8, 2024 18:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

The image is available at:

@04kash
Copy link
Member Author

04kash commented Nov 9, 2024

/retest

@PatAKnight
Copy link
Member

/test e2e-tests

PatAKnight
PatAKnight approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatAKnight, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PatAKnight,schultzp2020]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

New changes are detected. LGTM label has been removed.

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@04kash 04kash enabled auto-merge (squash) November 13, 2024 18:59
@04kash 04kash disabled auto-merge November 13, 2024 19:01
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2024

@04kash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests b8508bc link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@04kash
chore: update regex-actions wrapper
5ab3e50 
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatAKnight PatAKnight PatAKnight approved these changes

@schultzp2020 schultzp2020 schultzp2020 approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@schultzp2020 schultzp2020

@PatAKnight PatAKnight

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@04kash @PatAKnight @schultzp2020 @openshift-merge-robot