Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): enable RBAC tests RHIDP-4264 #1917

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

test(e2e): enable RBAC tests RHIDP-4264 #1917

wants to merge 60 commits into from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Nov 11, 2024 •
edited by openshift-ci bot
Loading

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@nilgaar
cleanup
8d9cb96 
split rbac tests

+ api improvements

replace by beforeAll by RhdhApi

delete redundant toBeTruthy

moving constants at top of methods

fix RhdhApi api url
@nilgaar
fix exposure apis URLs
e84c60a
@nilgaar
rbac text to skip to fixme
3d23977
@nilgaar
Merge branch 'main' into RHIDP-4264
cfc6a8b
@nilgaar
fix RhdhAuthHack
8641d6c
@nilgaar
fixing responseHelper
9417e12
@nilgaar
rhdh api auth hack as singleton
556a0ce
@nilgaar
fix rhdh api
b9c6004
@nilgaar
Merge branch 'main' into RHIDP-4264
3bbe27c
@nilgaar
minor improvements RHDH api
68610f3
@nilgaar
-not rhdh api yet
7379f65 
back to responseHelper
@nilgaar
Merge branch 'main' into RHIDP-4264
eddbb1f
@nilgaar
adapt RhdhAuthHack
8ba3a95 
retrieve removeMetadataFromResponse

delete useless awaits
@nilgaar
delete serial from RBAC plugin as an admin user
14c0c25
@nilgaar
Merge branch 'main' into RHIDP-4264-2
4679c21
@nilgaar
delete fixme anotation
754d4d2
@nilgaar
Merge branch 'main' into RHIDP-4264-2
07b8506
@nilgaar
delete fixme comment
a916288
@nilgaar
Merge branch 'main' into RHIDP-4264-2
03bdf61
@nilgaar
fixing: Create and edit a role from the roles list page
4537d2b
@nilgaar
enforce testIds
dc5b480
@nilgaar
Merge branch 'main' into RHIDP-4264-2
9612deb
@nilgaar
RhdhAuthHack goes back to previous page
48e70bc 
small hack

Fixture for rbac

delete through api

various fixes

rename files, et rbac admin value

delete timeouts for rbac test

undo hack

refresh before test

delete RhdhApi

add serial to RBAC admin tests

minor improvements
@nilgaar
Merge branch 'main' into RHIDP-4264-2
4e883ba
@nilgaar
minor improvement
8e37742
@nilgaar
improve logIntoGitHub
f356c6a
@nilgaar
delete unnecessari reloads
ee8e931
@nilgaar
renames and timeout set
74d312d
@nilgaar
Merge branch 'main' into RHIDP-4264-2
bab66b2
@nilgaar
Merge branch 'main' into RHIDP-4264-2
bd05671
@nilgaar nilgaar requested a review from a team as a code owner November 11, 2024 10:23
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nilgaar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@nilgaar nilgaar changed the title tests(e2e): enable RBAC tests RHIDP-4264 test(e2e): enable RBAC tests RHIDP-4264 Nov 12, 2024
@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 12, 2024

/retest

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2024

@nilgaar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 52215c1 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albarbaro albarbaro Awaiting requested review from albarbaro

@zdrapela zdrapela Awaiting requested review from zdrapela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilgaar @openshift-merge-robot