Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Add values for dynamic backend plugin support #111

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Sep 13, 2023

Signed-off-by: David Festal dfestal@redhat.com

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@davidfestal davidfestal requested a review from a team September 13, 2023 13:53
charts/backstage/values.yaml Outdated Show resolved Hide resolved
charts/backstage/values.yaml Outdated Show resolved Hide resolved
charts/backstage/values.yaml Outdated Show resolved Hide resolved
charts/backstage/values.yaml Outdated Show resolved Hide resolved
charts/backstage/values.yaml Outdated Show resolved Hide resolved
@davidfestal davidfestal changed the title [WIP] Add values for dynamic backend plugin support Add values for dynamic backend plugin support Sep 27, 2023
@davidfestal davidfestal force-pushed the dynamic-backend-plugins branch 5 times, most recently from 00116f6 to dc071ef Compare October 2, 2023 08:53
@davidfestal davidfestal linked an issue Oct 4, 2023 that may be closed by this pull request
@davidfestal davidfestal force-pushed the dynamic-backend-plugins branch 6 times, most recently from 9259d0b to d435249 Compare October 24, 2023 16:15
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only minor cosmetic issues, see comments inline.

@@ -12,8 +16,12 @@ upstream:
image:
registry: quay.io
repository: janus-idp/backstage-showcase
tag: latest
tag: next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please default to latest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but afaict that will the CI tests. Should I temporarily change the tags in [CI default values](git push origin dynamic-backend-plugins:dynamic-backend-plugins) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact I have temporarily changed the CI test initContainer image tag to next in commit c20c21b.
With that tests should succeed.

charts/backstage/values.yaml Outdated Show resolved Hide resolved
charts/backstage/values.yaml Show resolved Hide resolved
charts/backstage/values.yaml Outdated Show resolved Hide resolved
@davidfestal davidfestal force-pushed the dynamic-backend-plugins branch 5 times, most recently from c20c21b to 32f3493 Compare October 30, 2023 15:16
@Zaperex
Copy link
Member

Zaperex commented Oct 30, 2023

Will also need to add the integrity field into the helm chart schema after janus-idp/backstage-showcase#670 is merged

"integrity": {
  "title": "Integrity checksum of the package. Optional for local packages. Supported algorithms include: `sha512`, `sha384` and `sha256`. Refer to https://w3c.github.io/webappsec-subresource-integrity/#integrity-metadata-description for more information",
  "type": "string"
}

@davidfestal
Copy link
Member Author

@tumido Is the PR OK for you now ?

I assume we'll have to wait for the new release of the showcase before merging it ?

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last revert required, otherwise lgtm.

.github/workflows/test.yml Outdated Show resolved Hide resolved
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Zaperex
Copy link
Member

Zaperex commented Nov 6, 2023

@davidfestal we still need to add the integrity field into the helm chart schema since janus-idp/backstage-showcase#670 and janus-idp/backstage-showcase#704 are merged.

@tumido tumido merged commit e845904 into janus-idp:main Nov 6, 2023
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Dynamic Plugins support in helm charts
3 participants