This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
fix: add health checks probes #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, @jesuino do you think this should be rather a patch or feature release? Your PR title suggests it should be a feature release however your chart version change is a patch release. |
|
Hello @tumido I think a patch release is better suitable for this issue. Thanks for pointing this. I just fixed the conflicts with main branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds the health check probes using the same value as the upstream commented probes:
https://github.com/backstage/charts/blob/main/charts/backstage/values.yaml#L162
This should be merged after janus-idp/backstage-showcase#567
Existing or Associated Issue(s)
janus-idp/backstage-showcase#565
Additional Information
This should fix the info dialog in Openshift, where it asks users to setup health checks
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.