Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

chore(ci): test with latest and next showcase images #124

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore(ci): test with latest and next showcase images #124

merged 1 commit into from
Oct 24, 2023

Conversation

kadel
Copy link
Member

@kadel kadel commented Oct 13, 2023

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@kadel kadel requested a review from a team October 13, 2023 14:40
@kadel
Copy link
Member Author

kadel commented Oct 19, 2023

@tumido, what do you think about this?

@tumido
Copy link
Member

tumido commented Oct 19, 2023

@kadel , do we want to potentially run all tests against both images or is this just one test case?

If it is just one test case, we should define it as one instead by adding a values file into this folder:

https://github.com/janus-idp/helm-backstage/tree/main/charts/backstage/ci

@kadel
Copy link
Member Author

kadel commented Oct 23, 2023

All tests against both images. I want to make sure that updates to this helm chart are not somehow incompatible with Janus current and future releases.

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit e1c9496 into janus-idp:main Oct 24, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants