-
Notifications
You must be signed in to change notification settings - Fork 54
fix: update default values to account for postgresql existingSecret #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion for enhancement 🙂
8886ea8
to
14d4a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a single comment, otherwise LGTM 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left few suggestions inline... I think we should be consistent with upstream in value priority.
In addition to that, I've fixed the thing you've mentioned as broken in the upstream Backstage chart:
67f1f1d
to
40ece3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 1 nit remaining. In addition to that, can you please rebase and bump the version once more? 🙂
40ece3b
to
af73e35
Compare
af73e35
to
4d34bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Description of the change
Adds two new functions that will be used to set the values at
upstream.backstage.extraEnvVars.valueFrom.secretKeyRef.name
andupstream.postgresql.primary.extraEnvVars.valueFrom.secretKeyRef.name
. These functions will check ifupstream.postgresql.auth.existingSecret
is set and set the above values to this value. Otherwise it will set them torelease-name-postgresql
Existing or Associated Issue(s)
existingSecret
for PostgreSQL is not respected by our default values #138Additional Information
I am setting this as a draft so that I can get it reviewed to ensure that this is the route that we wish to go.
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.