This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
fix: set route host properly when clusterRouterBase is set #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Set route host to the auto-generated value when
clusterRouterBase
is set.The desired manifest for helm should now match the expected host
Additional Information
Now it doesn't actually get Openshift to auto-generate it. It instead utilizes the
janus-idp.hostname
value which matches the auto-generated value.This will now require the
clusterRouterBase
to be properly configured or else the route host will be invalid and users will not be able to access the application via the Route.Before this change, the route will still be valid if
clusterRouterBase
is misconfigured and users will still be able to the application, but the backstage config will be incorrect.Existing or Associated Issue(s)
Fixes #136
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.