Added new blog for a new frontend plugin and its integration with backend plugin #233
Conversation
|
This is my first PR. Please let me know if I need to add anything or if I missed something. I have gotten this blog reviewed by my team, so the code/contents of the blog are technically correct but I'll welcome any feedback in case there is still something lacking and needs improvement. |
|
@Zaperex I've updated the blog code based on your feedback. Can you please review it and let me know if there are still issues? |
|
@sgahlot I think you missed some of the suggestions. Github probably collapsed those suggestions due to the number of suggestions I made. Also you won't need to squash the commits, since we do that when we merge the PR. |
|
Ah. My bad. Let me look at those as well. Thanks for pointing that out :-) |
|
Also no need to ping me for every single suggestion 😄, you can just reply without the ping or just make the changes in the commit and not reply to the suggestion. |
|
Sorry about too many pings. Will avoid it in future |
|
Fixed for remaining comments |
| #### Modify `package.json` | ||
|
|
||
| Modify `package.json` in the root directory by adding the following content in the `scripts` section (_just after the `start` script entry_): |
There was a problem hiding this comment.
| #### Modify `package.json` | |
| Modify `package.json` in the root directory by adding the following content in the `scripts` section (_just after the `start` script entry_): | |
| #### Modifying the `package.json` | |
| Modify the `package.json` in the root directory by adding the following content in the `scripts` section (_just after the `start` script entry_): |
|
@sgahlot Just 2 more small changes that I missed from the previous review, other than that it looks good to me. |
|
@Zaperex Updated for the 2 changes you recommended. |
|
@sgahlot you missed a few suggestions again. Github collapsed them again because of the number of suggestions |
|
Ah man. I must be going blind :-). Sorry about that. Let me try again |
|
Let me make these changes as well and commit |
|
@sgahlot Let me know if you still want to make the changes yourself, otherwise I'll merge the PR. |
|
@Zaperex sure, please go ahead with the merging of this PR. Much appreciated. |
What does this PR do / why we need it
This PR contains a new blog detailing how to create a new frontend plugin and integrate it with a backend plugin
Which issue(s) does this PR fix
Fixes #?
PR acceptance criteria
How to test changes / Special notes to the reviewer
Review the new blog by visiting
blog/2023/10/11/frontend-plugin