Skip to content

Commit

Permalink
refactor: do not split --tests filter by comma
Browse files Browse the repository at this point in the history
Otherwise tests title with comma get split into two test filters
  • Loading branch information
thetutlage committed Nov 22, 2023
1 parent 0e618da commit a9f9d55
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions src/config_manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,12 @@ export class ConfigManager {
* Processes a CLI argument and converts it to an
* array of strings
*/
#processAsArray(value: string | string[]): string[] {
return Array.isArray(value) ? value : value.split(',').map((item: string) => item.trim())
#processAsArray(value: string | string[], splitByComma: boolean): string[] {
return Array.isArray(value)
? value
: splitByComma
? value.split(',').map((item: string) => item.trim())
: [value]
}

/**
Expand All @@ -63,19 +67,19 @@ export class ConfigManager {
const filters: Filters = {}

if (this.#cliArgs.tags) {
filters.tags = this.#processAsArray(this.#cliArgs.tags)
filters.tags = this.#processAsArray(this.#cliArgs.tags, true)
}
if (this.#cliArgs.tests) {
filters.tests = this.#processAsArray(this.#cliArgs.tests)
filters.tests = this.#processAsArray(this.#cliArgs.tests, false)
}
if (this.#cliArgs.files) {
filters.files = this.#processAsArray(this.#cliArgs.files)
filters.files = this.#processAsArray(this.#cliArgs.files, true)
}
if (this.#cliArgs.groups) {
filters.groups = this.#processAsArray(this.#cliArgs.groups)
filters.groups = this.#processAsArray(this.#cliArgs.groups, false)
}
if (this.#cliArgs._ && this.#cliArgs._.length) {
filters.suites = this.#processAsArray(this.#cliArgs._)
filters.suites = this.#processAsArray(this.#cliArgs._, true)
}

return filters
Expand Down Expand Up @@ -120,7 +124,7 @@ export class ConfigManager {
*/
#getCLIReporters(): string[] | undefined {
if (this.#cliArgs.reporters) {
return this.#processAsArray(this.#cliArgs.reporters)
return this.#processAsArray(this.#cliArgs.reporters, true)
}
}

Expand Down

0 comments on commit a9f9d55

Please sign in to comment.