Test char formatting, replace mem::uninitialized with MaybeUninit #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core::mem::uninitialized
doesn't actually produce uninitialized memory anymore, as a mitigation. So it would be perf-equivalent or possibly faster to just use[0u8; 4]
here. But just in case someone cares about the performance of this code path, I ported over some standard library internals and adapted them to this use case so we can use an uninit buffer.