This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Added helper method and renamed action #2
Open
ProLoser
wants to merge
64
commits into
jaredhoyt:master
Choose a base branch
from
ProLoser:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: README.md controllers/components/wizard.php views/helpers/wizard.php
Adding stepTotal() convenience function to helper.
Wizard now extends 'Object' instead of 'Component' '$this->Session' replaced by , '$this->controller->Session' Added component dependency : function beforeRender(&$controller) { } AND function shutdown(&$controller) { }
CakePHP 2.0 Adaptations
Form data handling
function initialize($controller, $settings = array()) { $this->controller = $controller; Removed : Component::beforeRender($controller) Component::shutdown($controller) Component::beforeRedirect($controller, $url, $status=null, $exit=true)
I tried to use git mv but apparently it couldn't tell it was just a relocation of the files :/
$this->params() has been replaced in Cake 2.* CakeRequest is now used to access same
Added visibility keywords
Added visibility keywords
Added visibility keywords
Added visibility keywords
Addition of visibility keywords
Minor updates for 2.* compatibility which included fixing callback method signatures for initialize() and startup() and the addition of constructor method to handle $settings configuration array. Minor fixes to visibility keywords which should have been set as protected from previous commit.
Updated callback method signatures, visibility keywords (protected)
Add roaming option (any step is valid)
Replace trigger_error() with more the specific NotImplementedException for missing process Callbacks
Using NotImplementedException for missing process Callbacks
allows proper controller testing. http://book.cakephp.org/2.0/en/development/testing.html#testing-controllers
add return before every redirect()
* skie/master: fix cake2 style clean code formating. implements SaveAndBack mode for wizard Conflicts: Controller/Component/WizardComponent.php View/Helper/WizardHelper.php
Update README.md
CakePHP v2.0
* updated gitignore * updated gitignore and composer * improved WizardHelper code style * fixed WizardComponent code style
* updated gitignore * updated gitignore and composer * improved WizardHelper code style * fixed WizardComponent code style * added .travis.yml and a test file * improved travis config, removed wrong import * added phpcs to travis config * improved travis config * fixed travis phpcs path * improved documentation * fixed code style * improved unit test * fixed testInitialize() * fixed unit tests, added code coverage * adjusted coverage config * temporary commented out unused test code * added unit test, adjusted coverage config * adjusted unit tests * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage configuration * adjusted coverage configuration * improved unit test * improved documentation and code style, more unit testing * fixed typo * fixed undefined variable * fixed unit test * branch() method simplified and unit tested * improved code style * more unit tests * more unit tests * fixed unit test * fixed unit test * fixed unit test * adjusted codecov.io call * adjusted codecov call * improved unit test * improved unit test * more unit tests * fixed unit test * more unit tests * improved unit tests * improved unit tests * fixed unit tests * improved unit tests * improved unit tests * improved unit tests * simplified unit tests * improved unit tests * temporary comment out yet unused code * more unit tests * improved code style and unit tests * improved unit test * fixed unit test * improved code style, unit tests * fixed unit test * fixed $this->controller->data, improved unit tests * fixed unit test * improved unit test * unit tests * unit tests * more debug * unit tests * unit tests * more debug * more debug * more debug * more debug * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * code style, unit tests * fixed unit tests * more unit tests * added missing import * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * more unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * reenable stylecheck * fixed code style
* updated gitignore * updated gitignore and composer * improved WizardHelper code style * fixed WizardComponent code style * added .travis.yml and a test file * improved travis config, removed wrong import * added phpcs to travis config * improved travis config * fixed travis phpcs path * improved documentation * fixed code style * improved unit test * fixed testInitialize() * fixed unit tests, added code coverage * adjusted coverage config * temporary commented out unused test code * added unit test, adjusted coverage config * adjusted unit tests * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage configuration * adjusted coverage configuration * improved unit test * improved documentation and code style, more unit testing * fixed typo * fixed undefined variable * fixed unit test * branch() method simplified and unit tested * improved code style * more unit tests * more unit tests * fixed unit test * fixed unit test * fixed unit test * adjusted codecov.io call * adjusted codecov call * improved unit test * improved unit test * more unit tests * fixed unit test * more unit tests * improved unit tests * improved unit tests * fixed unit tests * improved unit tests * improved unit tests * improved unit tests * simplified unit tests * improved unit tests * temporary comment out yet unused code * more unit tests * improved code style and unit tests * improved unit test * fixed unit test * improved code style, unit tests * fixed unit test * fixed $this->controller->data, improved unit tests * fixed unit test * improved unit test * unit tests * unit tests * more debug * unit tests * unit tests * more debug * more debug * more debug * more debug * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * code style, unit tests * fixed unit tests * more unit tests * added missing import * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * more unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * reenable stylecheck * fixed code style * more unit tests * fixed code style * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * adjusted travis config
* updated gitignore * updated gitignore and composer * improved WizardHelper code style * fixed WizardComponent code style * added .travis.yml and a test file * improved travis config, removed wrong import * added phpcs to travis config * improved travis config * fixed travis phpcs path * improved documentation * fixed code style * improved unit test * fixed testInitialize() * fixed unit tests, added code coverage * adjusted coverage config * temporary commented out unused test code * added unit test, adjusted coverage config * adjusted unit tests * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage configuration * adjusted coverage configuration * improved unit test * improved documentation and code style, more unit testing * fixed typo * fixed undefined variable * fixed unit test * branch() method simplified and unit tested * improved code style * more unit tests * more unit tests * fixed unit test * fixed unit test * fixed unit test * adjusted codecov.io call * adjusted codecov call * improved unit test * improved unit test * more unit tests * fixed unit test * more unit tests * improved unit tests * improved unit tests * fixed unit tests * improved unit tests * improved unit tests * improved unit tests * simplified unit tests * improved unit tests * temporary comment out yet unused code * more unit tests * improved code style and unit tests * improved unit test * fixed unit test * improved code style, unit tests * fixed unit test * fixed $this->controller->data, improved unit tests * fixed unit test * improved unit test * unit tests * unit tests * more debug * unit tests * unit tests * more debug * more debug * more debug * more debug * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * code style, unit tests * fixed unit tests * more unit tests * added missing import * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * more unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * reenable stylecheck * fixed code style * more unit tests * fixed code style * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * adjusted travis config * Progress menu links made consistent * humanized steps in the helper * improved redirect link * improved redirect link
…iable (#22) * Wizard root session key is refactored to a configurable component variable. * fixed unit test * Moved sessionRootKey related code from initialize to startup to ease the configuration in a controller. * Setting session keys refactored to a private method. * Fixed variable name.
test type for $proceed
Update WizardComponent.php
* updated gitignore * updated gitignore and composer * improved WizardHelper code style * fixed WizardComponent code style * added .travis.yml and a test file * improved travis config, removed wrong import * added phpcs to travis config * improved travis config * fixed travis phpcs path * improved documentation * fixed code style * improved unit test * fixed testInitialize() * fixed unit tests, added code coverage * adjusted coverage config * temporary commented out unused test code * added unit test, adjusted coverage config * adjusted unit tests * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage config * adjusted coverage configuration * adjusted coverage configuration * improved unit test * improved documentation and code style, more unit testing * fixed typo * fixed undefined variable * fixed unit test * branch() method simplified and unit tested * improved code style * more unit tests * more unit tests * fixed unit test * fixed unit test * fixed unit test * adjusted codecov.io call * adjusted codecov call * improved unit test * improved unit test * more unit tests * fixed unit test * more unit tests * improved unit tests * improved unit tests * fixed unit tests * improved unit tests * improved unit tests * improved unit tests * simplified unit tests * improved unit tests * temporary comment out yet unused code * more unit tests * improved code style and unit tests * improved unit test * fixed unit test * improved code style, unit tests * fixed unit test * fixed $this->controller->data, improved unit tests * fixed unit test * improved unit test * unit tests * unit tests * more debug * unit tests * unit tests * more debug * more debug * more debug * more debug * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * code style, unit tests * fixed unit tests * more unit tests * added missing import * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * more unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * reenable stylecheck * fixed code style * more unit tests * fixed code style * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests * adjusted travis config * Progress menu links made consistent * humanized steps in the helper * improved redirect link * improved redirect link * persist url params on redirect * added debug * more debug * removed debug * adjusted url in the unit test * more debug * fixed url parsing in unit test * removed debug * support persistUrlParams in the WizardHelper * improved persist url params logic * mode debug * minor improvement * fixed passed param in the url * removed debug, fixed unit tests * Wizard root session key is refactored to a configurable component variable. * fixed unit test * Moved sessionRootKey related code from initialize to startup to ease the configuration in a controller. * Setting session keys refactored to a private method. * Fixed variable name. * #more unit tests * adjusted unit tests * better clear session in tests * unit tests adjusted * unit tests * unit tests improved * Some refactoring in order to reduce the number of redirects * more refactoring * more docs and reset the expected step in branch() * updates expected step after save() and updates steps after unbranch() is called * ensure the current step is set properly * Fixed indefinite loop bug. * used Router::reverseToArray() * updated cakephp version * restored deleted params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey so it's been a while but I merged all your latest changes into mine and added a convenience helper method.
Instead of doing
$this->Form->create('Model', array('url' => 'wizard/step1'))
You can now do
$this->Wizard->create('Model')
This is simply a wrapper for
$Form->create()
and adds the first parameter in a url-array.This way if you have other parameters you want passed (for me, I use a locale param) they will be retained.
I also personally felt
$Wizard->wizardAction
was redundant so I renamed it$Wizard->action