require.resolve('source-map-support') if using lerna #44
Conversation
|
nice. |
| banner: `require('${require.resolve('source-map-support/register')}')` | ||
| banner: `require('${ | ||
| // Is source-map-support installed as project dependency, or linked? | ||
| require.resolve('source-map-support').match(process.cwd()) |
There was a problem hiding this comment.
.indexOf(process.cwd()) === 0 would be more reliable than .match(process.cwd()) if .match here is String.prototype.match, not anything special.
There was a problem hiding this comment.
@sompylasar Can you clarify again? I considered indexOf, but found String.prototype.match to read better.
Thanks!
There was a problem hiding this comment.
match finds in any place of the string, but indexOf() === 0 ensures it's at the start.
There was a problem hiding this comment.
Oh, of course! I figured since it's /Users/Me/whatever the risk was low.
There was a problem hiding this comment.
@ericclemmons should we fix this on master with a new PR?
There was a problem hiding this comment.
the risk was low.
Yes. Low but not zero. The underlying intended logic is indexOf() === 0 here.
There was a problem hiding this comment.
@sompylasar feel free to submit a PR and I will release and bump version
There was a problem hiding this comment.
This banner is writing absolute paths on bundles, and it's hard to notice unless you are using some tests on CI like environment @jaredpalmer
There was a problem hiding this comment.
created a issue here #124
Fixes #42.
I couldn't do
hub pull-request -i 42: