Skip to content

Conversation

@Cd16d
Copy link
Contributor

@Cd16d Cd16d commented Dec 24, 2025

This change adjusts the ItemCard component to enforce a single-line title for episodes, even in a vertical layout, to prevent the series name from wrapping and pushing other elements down.

It also introduces a new @Preview for the vertical episode card to facilitate easier visualization of this layout.

This change adjusts the `ItemCard` component to enforce a single-line title for episodes, even in a vertical layout, to prevent the series name from wrapping and pushing other elements down.

It also introduces a new `@Preview` for the vertical episode card to facilitate easier visualization of this layout.
Copilot AI review requested due to automatic review settings December 24, 2025 16:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a layout issue in the ItemCard component where episode series names would wrap to multiple lines in vertical layouts, causing unwanted layout shifts. The fix ensures that episode titles are always displayed on a single line regardless of the layout direction.

Key Changes:

  • Modified the Text component logic to enforce single-line titles for episodes in both horizontal and vertical layouts
  • Added a new preview function for vertical episode cards to improve development workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…components/ItemCard.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Cd16d Cd16d changed the title fix: Ensure single-line title for episodes in vertical layout fix: limit vertical titles to 2 lines to fix resizing Dec 24, 2025
@Cd16d Cd16d changed the title fix: limit vertical titles to 2 lines to fix resizing fix: set vertical titles to 2 lines to fix resizing Dec 24, 2025
@jarnedemeulemeester
Copy link
Owner

I actually don't mind the resizing.
I do agree to limiting the seriesName to a single line in the vertical layout.
But I do not like that the minimum line count for movies in vertical mode is 2.
It just feels like wasted space to me.

This change wraps the text elements within a `Column` with a fixed height. This ensures that cards in the same row have their titles and subtitles aligned, regardless of whether a card is a movie (2 lines of text) or an episode (1 line of text).
@Cd16d
Copy link
Contributor Author

Cd16d commented Dec 27, 2025

New

Screen_Recording_20251226_225645_Findroid.Debug.mp4

Old

Screen_Recording_20251226_225756_Findroid.Debug.mp4

I think having the space always there is better than it appearing and disappearing while side scrolling.
I updated the code to replace minLines with a Column for displaying the text.

@Cd16d Cd16d changed the title fix: set vertical titles to 2 lines to fix resizing fix(home): fixed title vertical dimension Dec 27, 2025
@jarnedemeulemeester
Copy link
Owner

I have changed my mind, I do agree that the layout should not shift.

But setting a fixed height with a column does not work for two reasons:

  • When you have a movie with a short single line title. The extra space is highlighted when longpressing on a card. This highlight should only include the visible text and not the whitespace.
  • Some users may have set a larger system font size. In this case the text may be cut off at the bottom.

Once those are resolved we can move forward to merging this.

However I did just commit some of your changes in 34f7e95

@Cd16d Cd16d marked this pull request as draft December 31, 2025 12:07
@Cd16d
Copy link
Contributor Author

Cd16d commented Jan 6, 2026

Possible solution: the secondary text (e.g., episode name, year) now occupies a second line, preventing the card from resizing.

  • Displays the year for movies.
  • Displays the full date range for TV shows.
  • Display episode title for episode.
  • Makes the primary title bold for better readability (can be removed).
  • Makes clickable only the poster (looks cleaner)

Video

Screen_Recording_20260106_153800_Findroid.Debug.mp4

@Cd16d Cd16d marked this pull request as ready for review January 6, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants