refactor(nav): improve adaptive navigation #1121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the adaptive navigation logic to provide a better user experience across different device sizes and orientations. The new logic introduces the following changes: - Collapsed navigation rail for landscape phones, PCs, and landscape tablets. - New navigation bar medium for portrait tablets and foldables. - Standard bottom navigation bar for portrait phones.
There was a problem hiding this comment.
Pull request overview
This PR refactors the adaptive navigation implementation to provide a more responsive and device-appropriate navigation experience across different screen sizes and orientations. The changes leverage newer Material3 Adaptive Navigation Suite APIs to select appropriate navigation patterns based on device characteristics.
- Implements device-specific navigation patterns: collapsed navigation rail for landscape phones and tablets, medium navigation bar for portrait tablets/foldables, and standard bottom navigation bar for portrait phones
- Replaces the previous adaptive logic with explicit breakpoint-based decision tree using height and width constraints
- Vertically centers navigation items in rail layouts for improved visual hierarchy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…idth and CompactHeight
This commit updates `NavigationRoot.kt` to use fully qualified names for `WindowSizeClass` constants instead of static imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the adaptive navigation logic to provide a better user experience across different device sizes and orientations.
The new logic introduces the following changes: