Skip to content

feat(explore-attr-breakdowns): Adding chart tooltip actions #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(explore-attr-breakdowns): Adding chart tooltip actions #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d06f5bf
feat(explore-attr-breakdowns): Adding chart tooltip actions
Nov 30, 2025
fe3707d
feat(explore-attr-breakdowns): Implementing for default case
Nov 30, 2025
baba258
feat(explore-attr-breakdowns): Adding tooltip actions for comparison …
Nov 30, 2025
714c386
feat(explore-attr-breakdowns): Adding comments
Nov 30, 2025
e8545e9
feat(explore-attr-breakdowns): Adding comments
Nov 30, 2025
bbbeccc
feat(explore-attr-breakdowns): memoizing config
Nov 30, 2025
dca4f84
feat(explore-attr-breakdowns): Addressing cursor comments
Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 103 additions & 13 deletions static/app/views/explore/components/attributeBreakdowns/attributeDistributionChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import {Flex} from 'sentry/components/core/layout';
import {tct} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {ReactEchartsRef} from 'sentry/types/echarts';
import {
Actions,
useAttributeBreakdownsTooltip,
} from 'sentry/views/explore/hooks/useAttributeBreakdownsTooltip';

import type {AttributeDistribution} from './attributeDistributionContent';

Expand Down Expand Up @@ -96,15 +100,106 @@ export function Chart({
? `${value.slice(0, TOOLTIP_MAX_VALUE_LENGTH)}...`
: value
: '\u2014';
return [
'<div class="tooltip-series" style="padding: 0;">',
`<div><span class="tooltip-label" style="margin: 0 auto; text-align: center; padding:8px 20px; min-width: 100px; max-width: 300px; word-break: break-word; white-space: normal; overflow-wrap: anywhere;"><strong>${truncatedValue}</strong></span></div>`,
'</div>',
`<div class="tooltip-footer" style="display: flex; justify-content: center; padding: 4px;">${pct}</div>`,
'<div class="tooltip-arrow"></div>',
].join('');
return `
<div class="tooltip-series" style="padding: 0;">
<div
class="tooltip-label"
style="
display: flex;
justify-content: space-between;
gap: 20px;
margin: 0 auto;
padding: 10px;
min-width: 100px;
max-width: 300px;
"
>
<strong
style="
word-break: break-word;
white-space: normal;
overflow-wrap: anywhere;
"
>${truncatedValue}</strong>
<span>${pct}</span>
</div>
</div>
`.trim();
}, []);

const tooltipActionsHtmlRenderer = useCallback(
(value: string) => {
if (!value) return '';

const actionBackground = theme.gray200;
return [
'<div',
' class="tooltip-footer"',
' id="tooltipActions"',
' style="',
' display: flex;',
' justify-content: center;',
' align-items: center;',
' flex-direction: column;',
' padding: 0;',
' gap: 0;',
' "',
'>',
' <div',
` data-tooltip-action="${Actions.GROUP_BY}"`,
` data-tooltip-action-key="${attributeDistribution.name}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Group by attribute',
' </div>',
' <div',
` data-tooltip-action="${Actions.ADD_TO_FILTER}"`,
` data-tooltip-action-key="${attributeDistribution.name}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Add value to filter',
' </div>',
' <div',
` data-tooltip-action="${Actions.EXCLUDE_FROM_FILTER}"`,
` data-tooltip-action-key="${attributeDistribution.name}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Exclude value from filter',
' </div>',
' <div',
` data-tooltip-action="${Actions.COPY_TO_CLIPBOARD}"`,
` data-tooltip-action-key="${attributeDistribution.name}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Copy value to clipboard',
' </div>',
'</div>',
]
.join('\n')
.trim();
},
[theme.gray200, attributeDistribution.name]
);

const tooltipConfig = useAttributeBreakdownsTooltip({
chartRef,
formatter: toolTipFormatter,
chartWidth,
actionsHtmlRenderer: tooltipActionsHtmlRenderer,
});

const chartXAxisLabelFormatter = useCallback(
(value: string): string => {
const labelsCount = seriesData.length > 0 ? seriesData.length : 1;
Expand Down Expand Up @@ -166,12 +261,7 @@ export function Chart({
ref={chartRef}
autoHeightResize
isGroupedByDate={false}
tooltip={{
appendToBody: true,
trigger: 'axis',
renderMode: 'html',
formatter: toolTipFormatter,
}}
tooltip={tooltipConfig}
grid={{
left: 2,
right: 8,
Expand Down
148 changes: 112 additions & 36 deletions static/app/views/explore/components/attributeBreakdowns/cohortComparisonChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {useCallback, useLayoutEffect, useMemo, useRef, useState} from 'react';
import type {Theme} from '@emotion/react';
import styled from '@emotion/styled';
import type {TooltipComponentFormatterCallbackParams} from 'echarts';
import type {CallbackDataParams} from 'echarts/types/dist/shared';

import {Tooltip} from '@sentry/scraps/tooltip/tooltip';

Expand All @@ -12,6 +11,10 @@ import {tct} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {ReactEchartsRef} from 'sentry/types/echarts';
import type {AttributeBreakdownsComparison} from 'sentry/views/explore/hooks/useAttributeBreakdownComparison';
import {
Actions,
useAttributeBreakdownsTooltip,
} from 'sentry/views/explore/hooks/useAttributeBreakdownsTooltip';

const MAX_BAR_WIDTH = 20;
const HIGH_CARDINALITY_THRESHOLD = 20;
Expand Down Expand Up @@ -164,50 +167,129 @@ export function Chart({
[attribute.cohort1, attribute.cohort2, cohort1Total, cohort2Total]
);

const toolTipValueFormatter = useCallback(
(_value: number, _label?: string, seriesParams?: CallbackDataParams) => {
const percentage = Number(seriesParams?.data);
return percentageFormatter(percentage);
},
[]
);

const toolTipFormatAxisLabel = useCallback(
(
_value: number,
_isTimestamp: boolean,
_utc: boolean,
_showTimeInTooltip: boolean,
_addSecondsToTimeFormat: boolean,
_bucketSize: number | undefined,
seriesParamsOrParam: TooltipComponentFormatterCallbackParams
) => {
if (!Array.isArray(seriesParamsOrParam)) {
const toolTipFormatter = useCallback(
(p: TooltipComponentFormatterCallbackParams) => {
if (!Array.isArray(p)) {
return '\u2014';
}

const selectedParam = seriesParamsOrParam.find(
s => s.seriesName === SELECTED_SERIES_NAME
);
const baselineParam = seriesParamsOrParam.find(
s => s.seriesName === BASELINE_SERIES_NAME
);
const selectedParam = p.find(s => s.seriesName === SELECTED_SERIES_NAME);
const baselineParam = p.find(s => s.seriesName === BASELINE_SERIES_NAME);

if (!selectedParam || !baselineParam) {
throw new Error('selectedParam or baselineParam is not defined');
}

const name = selectedParam?.name ?? baselineParam?.name ?? '';
const selectedValue = selectedParam.value;
const baselineValue = baselineParam.value;
const selectedPct = percentageFormatter(Number(selectedValue));
const baselinePct = percentageFormatter(Number(baselineValue));

const name = selectedParam.name ?? baselineParam.name ?? '';
const truncatedName =
name.length > TOOLTIP_MAX_VALUE_LENGTH
? `${name.slice(0, TOOLTIP_MAX_VALUE_LENGTH)}...`
: name;

return `<div style="max-width: 200px; white-space: normal; word-wrap: break-word; line-height: 1.2; color: black;">${truncatedName}</div>`;
return `
<div data-explore-chart-selection-region class="tooltip-series" style="padding: 0;">
<div class="tooltip-label" style="display: flex; flex-direction: column; align-items: stretch; gap: 10px; margin: 0 auto; padding: 10px; min-width: 100px; max-width: 300px;">
<strong style="word-break: break-word; white-space: normal; overflow-wrap: anywhere; text-align: center;">${truncatedName}</strong>
<span style="display: flex; align-items: center; justify-content: space-between; gap: 10px;">
<span style="display: flex; align-items: center; gap: 6px;">
<span style="width: 8px; height: 8px; border-radius: 50%; background-color: ${cohort1Color}; display: inline-block;"></span>
selected
</span>
<span>${selectedPct}</span>
</span>
<span style="display: flex; align-items: center; justify-content: space-between; gap: 10px;">
<span style="display: flex; align-items: center; gap: 6px;">
<span style="width: 8px; height: 8px; border-radius: 50%; background-color: ${cohort2Color}; display: inline-block;"></span>
baseline
</span>
<span>${baselinePct}</span>
</span>
</div>
</div>
`.trim();
},
[cohort1Color, cohort2Color]
);

const tooltipActionsHtmlRenderer = useCallback(
(value: string) => {
if (!value) return '';

const actionBackground = theme.gray200;
return [
'<div',
' data-explore-chart-selection-region',
' class="tooltip-footer"',
' id="tooltipActions"',
' style="',
' display: flex;',
' justify-content: center;',
' align-items: center;',
' flex-direction: column;',
' padding: 0;',
' gap: 0;',
' "',
'>',
' <div',
` data-tooltip-action="${Actions.GROUP_BY}"`,
` data-tooltip-action-key="${attribute.attributeName}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Group by attribute',
' </div>',
' <div',
` data-tooltip-action="${Actions.ADD_TO_FILTER}"`,
` data-tooltip-action-key="${attribute.attributeName}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Add value to filter',
' </div>',
' <div',
` data-tooltip-action="${Actions.EXCLUDE_FROM_FILTER}"`,
` data-tooltip-action-key="${attribute.attributeName}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Exclude value from filter',
' </div>',
' <div',
` data-tooltip-action="${Actions.COPY_TO_CLIPBOARD}"`,
` data-tooltip-action-key="${attribute.attributeName}"`,
` data-tooltip-action-value="${value}"`,
' style="width: 100%; padding: 8px 20px; cursor: pointer;"',
` onmouseover="this.style.background='${actionBackground}'"`,
' onmouseout="this.style.background=\'\'"',
' >',
' Copy value to clipboard',
' </div>',
'</div>',
]
.join('\n')
.trim();
},
[]
[theme.gray200, attribute.attributeName]
);

const tooltipConfig = useAttributeBreakdownsTooltip({
chartRef,
formatter: toolTipFormatter,
chartWidth,
actionsHtmlRenderer: tooltipActionsHtmlRenderer,
});

const chartXAxisLabelFormatter = useCallback(
(value: string): string => {
const selectedSeries = seriesData[SELECTED_SERIES_NAME];
Expand Down Expand Up @@ -276,13 +358,7 @@ export function Chart({
ref={chartRef}
autoHeightResize
isGroupedByDate={false}
tooltip={{
appendToBody: true,
trigger: 'axis',
renderMode: 'html',
valueFormatter: toolTipValueFormatter,
formatAxisLabel: toolTipFormatAxisLabel,
}}
tooltip={tooltipConfig}
grid={{
left: 2,
right: 8,
Expand Down
Loading
Loading