Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename standard posthoc test to standard (LSD) and footnote for Dunn's test #166

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

JTPetter
Copy link
Contributor

@JTPetter JTPetter commented Jun 13, 2022

As requested by EJ: Someone asked to verify that the standard option for the post hoc test uses Fisher's LSD method. This was not clear from the interface/helpfile

Do I also need to change this in the Dutch helpfiles? Or are they generated automatically?

Fixes jasp-stats/jasp-issues#1123

@JohnnyDoorn
Copy link
Contributor

Do I also need to change this in the Dutch helpfiles? Or are they generated automatically?

I think Weblate will automatically pick up the change, and suggest is for the next round of translations (thoughI think it will be the same in all languages)

@Kucharssim
Copy link
Member

The help files are currently not translated in Weblate, so changes need to be done manually...

@JTPetter
Copy link
Contributor Author

Okay, I have added it to the Dutch help files

@JTPetter
Copy link
Contributor Author

... and the container titles

@Kucharssim
Copy link
Member

can you fix the conflicts?

@JTPetter
Copy link
Contributor Author

@Kucharssim I completely missed this! I have rebased everything now...

@JTPetter JTPetter requested a review from Kucharssim June 30, 2023 13:42
@JTPetter JTPetter changed the title Rename standard posthoc test to standard (LSD) Rename standard posthoc test to standard (LSD) and footnote for Dunn's test Jan 19, 2024
@JTPetter
Copy link
Contributor Author

Rebased again and also fixes jasp-stats/jasp-issues#1123 now

@JTPetter
Copy link
Contributor Author

@Kucharssim could you review/merge please?

@Kucharssim Kucharssim merged commit 7308959 into jasp-stats:master Jan 19, 2024
2 of 5 checks passed
@tomtomme
Copy link
Member

tomtomme commented Mar 12, 2024

Sorry for the late intervention... but currently only the output table is renamed. Shouldn't the analysis GUI
image
also be renamed from "standard" to "standard (LSD)" or even "Fishers LSD" - since the term "standard" does not mean or explain anything and currently "Fisher" is not even mentioned in the help file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dunn's P values: Add p-value explainer footnote
4 participants