Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bayesian descriptives Credible Interval #283

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

vandenman
Copy link
Contributor

Fixes jasp-stats/jasp-issues#2153
Fixes jasp-stats/jasp-issues#2190

descriptivePlotCiLevel should have been credibleInterval.

New output:

image

@vandenman
Copy link
Contributor Author

@shun2wang about the failing i18n-check:

Error_Location   "po/R-pl.po:742"                                                                                                                                                                                                                                                                                                
Error_Type       "too many entries"                                                                                                                                                                                                                                                                                              
Original_Gettext "For some affected models, more than 75%% of the posterior samples failed, or fewer than 1000 samples remained for subsequent results. All model-averaged output may be biased and uninterpretable. Check the model specification and data for any odd patterns."                                               
Translated_text  "W przypadku niektórych zmodyfikowanych modeli ponad 75% próbek posterior nie powiodło się lub pozostało mniej niż 1000 próbek dla kolejnych wyników. Wszystkie uśrednione wyniki mogą być obciążone błędem i niemożliwe do zinterpretowania. Sprawdź specyfikację modelu i dane pod kątem nietypowych wzorców."
✖ 1 multiple placeholders without index found

There should be %% in the Polish translation? So I'll fix it through weblate and leave this error for now.

In the second error

✖ 1 multiple placeholders without index found

── Please refer to following to resolve them: ──

                  file
 commonAnovaBayesian.R
                                                                                                                    call
 ngettext( length(tempNuisance), "Null model (incl. %s and random slopes)", "Null model (incl. %s, and random slopes)" )
 line_number
         365

it should be fine that there is no index because there is only one placeholder? Is this a false positive in the i18-check or am I missing something?

@shun2wang
Copy link
Contributor

for first one: yes, it should be fix on weblate.
for second error: I'll modify the regular expression to match this, so you can ignore it.

@vandenman vandenman merged commit ca354b4 into jasp-stats:master Jun 29, 2023
3 of 5 checks passed
@vandenman vandenman deleted the fixDescriptivesCI branch June 29, 2023 12:40
@umhan35
Copy link

umhan35 commented Jul 10, 2023

Is it also fixed in post hoc tests? I am using the latest 0.17.3 but still don't see CI there.

@boutinb
Copy link
Contributor

boutinb commented Jul 11, 2023

0.17.3 is not officially released yet. But that's true that this fix was not yet added in the repository. I have just added it.

@RensDofferhoff
Copy link
Contributor

@umhan35 A new flatpak is currently being build. It will take 3 hours if all goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants