Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use visible property in place of a loader #298

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

boutinb
Copy link
Contributor

@boutinb boutinb commented Oct 30, 2023

@Kucharssim
Copy link
Member

So this means that ANCOVA and RM ANOVA wrappers in R would receive additional arguments even though they shouldn't, right? Because setting visible to false does not equal not having that argument in the first place

@boutinb boutinb merged commit 762a678 into jasp-stats:master Oct 30, 2023
1 check passed
@boutinb
Copy link
Contributor Author

boutinb commented Oct 30, 2023

@Kucharssim You are right... But the default setting is homogeneityCorrectionNone is true and the rest is false, and in the R code I see:

 # Set corrections to FALSE when performing ANCOVA
  if (is.null(options$homogeneityCorrectionBrown)) {
    options$homogeneityCorrectionNone <- TRUE
    options$homogeneityCorrectionBrown <- FALSE
    options$homogeneityCorrectionWelch <- FALSE
  }

So there is no need to use a complexify the QML with a Loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants