embarassing bugfix for single model inference #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw the test fail, but it seems the failures are unrelated to this PR. Worryingly the tests fail for the "Field results match" tests that were verified against Andy Field's textbooks, so we should probably look into it asap. @JohnnyDoorn, would you have time to look into these tests? |
|
those tests have failed for me for a long time, but then they at least always passed online. Shall I merge this PR for now and @JohnnyDoorn can look into the test failures afterward? |
|
Yes you can merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2426
This one slipped through the cracks in 24fdb15#diff-1d795fbb2f5b192562c6e4314352402f77cd39751d8086ff08c19bbb7d1bcbf9R3277
also adds a unit test.
Note, this is still intended for the upcoming release, I was just a bit slow with making a PR.