Skip to content

Allow to send notifications and to skip bumping VERSION_FILE#19

Closed
exAspArk wants to merge 2 commits intojaspernbrouwer:masterfrom
exAspArk:notify
Closed

Allow to send notifications and to skip bumping VERSION_FILE#19
exAspArk wants to merge 2 commits intojaspernbrouwer:masterfrom
exAspArk:notify

Conversation

@exAspArk
Copy link
Contributor

@exAspArk exAspArk commented Jul 12, 2016

Hi,

We currently use git-flow-hooks to send notifications in our Slack channel and Hipchat room. It's very useful to track release and hotfix changes, especially for those who don't work with repository directly. So we also decided to specify versions manually as it is quite easy to see all previous versions in a messenger.

I thought it might be useful for someone else.

@exAspArk exAspArk force-pushed the notify branch 2 times, most recently from c2729a9 to a490a70 Compare July 13, 2016 07:59
@exAspArk exAspArk force-pushed the notify branch 2 times, most recently from 7d89359 to b83f6b3 Compare August 23, 2016 10:13
@jaspernbrouwer
Copy link
Owner

Hi there! Finally you might think 😉

Allowing to not use a version-file is actually a cool idea, and I'd like to integrate that!

Sending notifications is also cool, but I'm not sure which way to go on that. These kind of features have been asked before, and I've seen some forks with nice additions in that regard, but the actual implementation has always been rather straightforward. Not that that's a down-side per se, but I envision a more plugin-like structure where users can add these in a more uniform way. Unfortunately that would take some time and testing to implement.

So, if I may be so blunt, I have two questions:

  1. Can you split this PR up into 2 PRs? 1 containing the functionality to disable the version-file (which I will merge for sure!). The other ...
  2. Can you add a section to the readme where you point to you own fork, where you add the sending notifications functionality? This will give me some room to think about / implement a more robust structure, while others are pointed to the right location if they want it now 😄 .

@exAspArk
Copy link
Contributor Author

exAspArk commented Sep 16, 2016

@jaspernbrouwer glad to hear from you 😸

Thanks for your feedback. Supporting a plugin-like structure sounds like a great idea!

I've opened 2 separate PRs:

  1. Allow to skip writing to the VERSION_FILE #20Allow to skip writing to the VERSION_FILE
  2. Add link to the fork which sends notifications to Slack / HipChat #21Add link to the fork which sends notifications to Slack / HipChat

Closing this PR then

@exAspArk exAspArk closed this Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants