-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flag to not generate Move or Copy operations. #81
base: master
Are you sure you want to change the base?
Conversation
Can you rename the param from "moveOrCopy" to "diffDoentRequireSource" or something more semantic about what is trying to be achieved. i.e. we shouldn't include test as well if that ever came up. |
Done. I'm not sure I have understand what you say about test. Maybe I should create an option objet that could evolve, rather than a boolean directly in constructor ? |
A boolean paramter to determine behaviour might be a code smell. I was thinking of solving this in a different way by extracting an interface from |
@huggsboson I create a DiffOptions class and a builder, to pass 'diffDoentRequireSource' option, I think it's more flexible. Build don't pass, there is a problem with a gradle dependency : http://repo.springsource.org/plugins-release/org/springframework/build/gradle/propdeps-plugin/0.0.7/propdeps-plugin-0.0.7.pom are only accessible on https. I don't know how to solve this, and I think is not reliable directly to my PR or the java-json-tool project. |
} | ||
|
||
|
||
public static JsonNode asJson(final JsonNode source, final JsonNode target, final boolean withMoveOrCopyOperation) | ||
public static JsonNode asJson(final JsonNode source, final JsonNode target, DiffOptions options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options param should be final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
could you show us your idea ? |
I'd like to see this feature become available. Is there anything else still needed for this? |
I need a patch without reference to the json source.
Related to issue #46