Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to not generate Move or Copy operations. #81

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bdwdax
Copy link

@bdwdax bdwdax commented Aug 28, 2020

I need a patch without reference to the json source.

Related to issue #46

@huggsboson
Copy link
Member

huggsboson commented Sep 1, 2020

Can you rename the param from "moveOrCopy" to "diffDoentRequireSource" or something more semantic about what is trying to be achieved. i.e. we shouldn't include test as well if that ever came up.

@bdwdax
Copy link
Author

bdwdax commented Sep 4, 2020

Done. I'm not sure I have understand what you say about test.

Maybe I should create an option objet that could evolve, rather than a boolean directly in constructor ?

@jonas-grgt
Copy link

A boolean paramter to determine behaviour might be a code smell.

I was thinking of solving this in a different way by extracting an interface from DiffProcessor with two implementations SourcedDiffProcessor and SourcelessDiffProcessor ( maybe the names could be better ) with two well defined static factory methods in the JsonDiff class.

@bdwdax
Copy link
Author

bdwdax commented Sep 24, 2020

@huggsboson I create a DiffOptions class and a builder, to pass 'diffDoentRequireSource' option, I think it's more flexible.

Build don't pass, there is a problem with a gradle dependency : http://repo.springsource.org/plugins-release/org/springframework/build/gradle/propdeps-plugin/0.0.7/propdeps-plugin-0.0.7.pom are only accessible on https. I don't know how to solve this, and I think is not reliable directly to my PR or the java-json-tool project.

}


public static JsonNode asJson(final JsonNode source, final JsonNode target, final boolean withMoveOrCopyOperation)
public static JsonNode asJson(final JsonNode source, final JsonNode target, DiffOptions options)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options param should be final

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bdwdax
Copy link
Author

bdwdax commented Sep 24, 2020

A boolean paramter to determine behaviour might be a code smell.

I was thinking of solving this in a different way by extracting an interface from DiffProcessor with two implementations SourcedDiffProcessor and SourcelessDiffProcessor ( maybe the names could be better ) with two well defined static factory methods in the JsonDiff class.

could you show us your idea ?

@techanon
Copy link

techanon commented Dec 7, 2021

I'd like to see this feature become available. Is there anything else still needed for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants