unwinder: Fix assumption on thread's initial registers #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The x86_64 ABI mandates that the bottom frame of processes must have their frame pointer (rbp) set to zero. We check for this when we detect and end of stacktrace condition, which is correcto for processes but it's not for threads as their initial frame pointer value is not specified. Test Plan ========= Ran for a while without issues. Unwinding Node.js applications cause the log to show up, this needs more investigation, but in general we should always use frame pointers to unwind Node. We will revisit this once we add proper support for this runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The x86_64 ABI mandates that the bottom frame of processes must have their frame pointer (rbp) set to zero. We check for this when we detect and end of stacktrace condition, which is correcto for processes but it's not for threads as their initial frame pointer value is not specified.
Test Plan
Ran for a while without issues. Unwinding Node.js applications cause the log to show up, this needs more investigation, but in general we should always use frame pointers to unwind Node. We will revisit this once we add proper support for this runtime.