Document 14 code smells with actionable issue templates

[Copilot]

Analyzed codebase and identified 14 code quality issues ranging from bugs to architectural smells.

Deliverables

Master Documentation (CODE_SMELLS.md)

• Catalog of all issues with severity, location, impact, and remediation
• Prioritized recommendations (1 high, 8 medium, 5 low)

Issue Templates (docs/issues/*.md)

• 14 ready-to-use GitHub issue templates
• Each includes: precise location, code examples, acceptance criteria, related issues
• Automated creation script for bulk issue generation

Key Findings

Critical Bugs

• Duplicate assignment: amount = amount = float(...) in HeyBancoParser (2 instances)
• Rappi parser fetches body_plain twice instead of falling back to HTML
• Logging bug: category_id logged twice, subcategory_id never captured

Structural Issues

• Spanish month mappings duplicated across 4 parsers
• Date normalization logic duplicated in 2 methods (~27 lines each)
• 67-line method with 6 responsibilities
• Double database commit (atomicity + performance issue)
• email_message dict passed inconsistently without type contract

Code Quality

• Magic number: maxResults=500 hardcoded
• Missing explicit return None
• Dead code: PAYPAL defined but parser commented out
• Class variable shadowing instance variable

Usage

# Create all issues
cd docs/issues && ./create-all-issues.sh

# Or manually using individual templates
gh issue create --title "Bug: Variable Shadowing" --body-file 08-variable-shadowing-bug.md

Quick Wins

Four one-line fixes available:

• Lines 78, 117 in hey_banco.py (duplicate assignment)
• Line 55 in rappi.py (wrong dict key)
• Line 60 in transaction_service.py (logging typo)

Original prompt

create issues for code smells

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.