-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed useless regex characters escape #721
base: master
Are you sure you want to change the base?
Conversation
The search code used to use 'string'.search which takes regex input. Now it used indexOf, so escaping is unnecessary and causes search to break after on of the special characters is entered. From: javve#721
Would like to +1 this PR. Fixing search is important to our use of list.js. |
I would also like to +1 this request. Seems a shame to leave an important feature broken if the work has already been done to fix it. |
Another +1. Wanted to use this library, but immediately encountered this problem. This has been neglected for over a year, so... I guess this project is dead? |
+1 for this request |
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above. Futher detail: Prior to v2.3.0, the search used regexp, so special chars had to be escaped. However version 2.3.0 implemented a new, faster search which didn't use regexp. Therefore by continuing to escape special chars, it's not possible to search for them. This defunct 'replace' function should be removed
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above. Futher detail: Prior to v2.3.0, the search used regexp, so special chars had to be escaped. However version 2.3.0 implemented a new, faster search which didn't use regexp. Therefore by continuing to escape special chars, it's not possible to search for them. This defunct 'replace' function should be removed
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above. Futher detail: Prior to v2.3.0, the search used regexp, so special chars had to be escaped. However version 2.3.0 implemented a new, faster search which didn't use regexp. Therefore by continuing to escape special chars, it's not possible to search for them. This defunct 'replace' function should be removed
+1 for the request. The project looks dead to me? Then better to find an alternative. |
@javve : any chance this can be merged, or the author can be added as a contributor ? That would fix a bug in SQLPage (and many other dependent projects, I guess) |
If anyone needs to depend on a package on npm with the fix, I published: https://www.npmjs.com/package/list.js-fixed |
+1 Same issue there. |
Fixes #699