Merge pull request #5 from jawira/4-search-plantuml-in-path

feat: Checks if PlantUml is installed as Path variable

src/PlantUml.php

@@ -29,9 +29,11 @@ public function setJar(string $path): self
 
   /**
    * Convert diagram  into requested format.
+   *
    * @param string $diagram This is the diagram to be converted, you must provide the diagram itself and not a file
    *                        path. Otherwise, it's up to you to load that file into a variable.
    * @param string $format  Must be a valid PlantUml format: `png`, `svg`, `eps`, `txt`, ...
+   * @throws \Jawira\PlantUmlToImage\PlantUmlException
    */
   public function convertTo(string $diagram, string $format): string
   {
@@ -50,6 +52,7 @@ public function convertTo(string $diagram, string $format): string
    * Returns PlantUml Jar or Executable, if not found `plantuml` is returned by default.
    *
    * @return string[]
+   * @throws \Jawira\PlantUmlToImage\PlantUmlException
    */
   protected function findPlantUml(): array
   {
@@ -65,7 +68,7 @@ protected function findPlantUml(): array
       return $candidate;
     }
 
-    return ['plantuml'];
+    throw new PlantUmlException('Cannot found PlantUml, try installing `plantuml/jawira`.');
   }
 
   /**
@@ -131,6 +134,21 @@ protected function findExecutable(): ?array
       return [$candidate];
     }
 
+    if ($this->isPlantUmlInPath()) {
+      return ['plantuml'];
+    }
+
     return null;
   }
+
+  /**
+   * Checks `plantuml` is located as path variable.
+   */
+  protected function isPlantUmlInPath(): bool
+  {
+    $process = Process::fromShellCommandline('plantuml -help');
+    $process->run();
+
+    return 0 === $process->getExitCode();
+  }
 }

src/PlantUmlException.php

@@ -0,0 +1,9 @@
+<?php declare(strict_types=1);
+
+namespace Jawira\PlantUmlToImage;
+
+use Exception;
+
+class PlantUmlException extends Exception
+{
+}

tests/ProcessTest.php

@@ -10,7 +10,9 @@ class ProcessTest extends TestCase
 {
   /**
    * @dataProvider svgConversionProvider
-   * @covers       \Jawira\PlantUmlToImage\PlantUmlProcess::convertTo
+   * @covers       \Jawira\PlantUmlToImage\PlantUml::convertTo
+   * @covers       \Jawira\PlantUmlToImage\PlantUml::findJar
+   * @covers       \Jawira\PlantUmlToImage\PlantUml::findPlantUml
    * @testdox      Svg from $filePath contains '$needle' .
    */
   function testSvgConversion($filePath, $needle, $bytes)