[array API] support copy argument to jnp.asarray #19186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
yashk2810
approved these changes
Jan 4, 2024
| view = memoryview(obj) | ||
| except TypeError: | ||
| return False | ||
| else: |
There was a problem hiding this comment.
Instead of else, can you return True in the try block directly?
There was a problem hiding this comment.
The principle I'm following here is to put as little as possible in the try: block to avoid catching unexpected exceptions. But admittedly I think it's very unlikely that return True would raise an exception 😁 ... still style-wise I marginally prefer the else block anyway. What do you think?
There was a problem hiding this comment.
Sure, sounds good. For me the else is very confusing and I have to look it up everytime ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18353
The semantics of
copyfollow the specification here: https://data-apis.org/array-api/2022.12/API_specification/generated/array_api.asarray.html