Pipe tiled through all_to_all primitive
#19854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_607775078
branch
7 times, most recently
from
0837072
to
ab1e1c8
Compare
copybara-service
bot
force-pushed
the
test_607775078
branch
6 times, most recently
from
5b3257d
to
dbb422f
Compare
copybara-service
bot
force-pushed
the
test_607775078
branch
2 times, most recently
from
981ca06
to
5c87844
Compare
The `_all_to_all_transpose_rule` calls `all_to_all` which can accept a `tiled` argument. Thus, for the transpose to know the right value of `tiled` to pass, we need to plumb the `tiled` argument through the primitive and various interpreters, even though it's a no-op because the `tiled` argument is handled outside the primitive. It would be cleaner to handle `tiled` inside the primitive, but I will leave that for followup work. Fixes #15982. PiperOrigin-RevId: 612628600
copybara-service
bot
force-pushed
the
test_607775078
branch
from
5c87844
to
3fe65e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe
tiledthroughall_to_allprimitiveThe
_all_to_all_transpose_rulecallsall_to_allwhich can accept atiledargument. Thus, for the transpose to know the right value of
tiledto pass, weneed to plumb the
tiledargument through the primitive and variousinterpreters, even though it's a no-op because the
tiledargument is handledoutside the primitive. It would be cleaner to handle
tiledinside theprimitive, but I will leave that for followup work.
Fixes #15982.