[mutable-arrays] move MutableArray, add eager, improve tests, fix bug #20044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mattjj
commented
Mar 1, 2024
mattjj
commented
- move MutableArray to core.py, and some handlers to their respective files
- fix a bug in aliasing setup (it was just broken before, now better test coverage)
- add eager support by enabling get_p, swap_p, and addupdate_p impls
- improve tests slightly
mattjj
force-pushed
the
mutable-arrays
branch
2 times, most recently
from
db28f5e
to
3e68277
Compare
froystig
approved these changes
Mar 1, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
mattjj
force-pushed
the
mutable-arrays
branch
2 times, most recently
from
2a0c5ec
to
3a94a4e
Compare
sharadmv
approved these changes
Mar 1, 2024
1. move MutableArray to core.py, and some handlers to their respective files 2. fix a bug in aliasing setup (it was just broken before, now better test coverage) 3. add eager support by enabling get_p, swap_p, and addupdate_p impls 4. improve tests slightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.