Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate newshape argument of jnp.reshape #21130

Merged
merged 1 commit into from
May 9, 2024
Merged

Deprecate newshape argument of jnp.reshape #21130

merged 1 commit into from
May 9, 2024

Conversation

Micky774
Copy link
Collaborator

@Micky774 Micky774 commented May 8, 2024

Towards #21088

Deprecate newshape argument of jnp.reshape in favor of shape, as per array API specification.

jakevdp
jakevdp approved these changes May 8, 2024
View reviewed changes
jax/_src/numpy/lax_numpy.py Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels May 8, 2024
@jakevdp jakevdp self-assigned this May 8, 2024
jakevdp
jakevdp requested changes May 8, 2024
View reviewed changes
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
jakevdp
jakevdp requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need the same change for the type signature in jax/numpy/__init__.pyi

jakevdp
jakevdp reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add a changelog entry, and then we can merge this!

jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
jakevdp
jakevdp approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@copybara-service copybara-service bot merged commit a9460f2 into jax-ml:main May 9, 2024
13 of 14 checks passed
@Micky774 Micky774 deleted the reshape branch May 9, 2024 21:52
@Micky774 Micky774 mentioned this pull request May 14, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Micky774 @jakevdp @kokoro-team