Add Scaled Dot Product Attention for FP8 #22670
Open
+1,011
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wenscarl is this ready to review? I can help with that. If possible, can you resolve the conflicts and run the pre-commit for the format consistency? |
|
It's ready for review and conflict fixed. Thanks! |
superbobry
requested changes
Sep 17, 2024
|
Yes. I will refactor changes to be in fused_attention_stablehlo.py |
wenscarl
force-pushed
the
fp8_sdpa
branch
3 times, most recently
from
accc056
to
db6e2b9
Compare
Merged into fused_attention_stablehlo.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaled Dot Product Attention for FP8. @kaixih @zhangqiaorjc