Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[array api] use jnp.astype directly #22794

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[array api] use jnp.astype directly #22794

merged 1 commit into from
Aug 1, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Jul 31, 2024 •
edited
Loading

Part of #18353 and #21088

We're still working on deprecating complex->real conversions (as required by the 2023.12 array API standard) but in the meantime I don't think this needs to be blocking.

Once this is in, I think we can do the swap over to using jax.numpy directly, and begin deprecating jax.experimental.array_api!

@jakevdp jakevdp requested a review from vfdev-5 July 31, 2024 18:53
@jakevdp jakevdp self-assigned this Jul 31, 2024
vfdev-5
vfdev-5 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Aug 1, 2024
@jakevdp
Copy link
Collaborator Author

jakevdp commented Aug 1, 2024

Thanks!

@copybara-service copybara-service bot merged commit b3924da into jax-ml:main Aug 1, 2024
17 checks passed
@jakevdp jakevdp deleted the array-api-astype branch August 1, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakevdp @vfdev-5 @kokoro-team