Simplify dtype registration logic #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks for already registered types were added in the precursor to ml_dtypes, when both JAX and tensorflow registered their own copies of bfloat16. Since that is no longer a concern, we can remove this logic.
jakevdp
force-pushed
the
cleanup-registration
branch
from
5680083 to
f2d24ca
Compare
|
There's still another followup here, to allocate dtypes statically rather than on the heap. I plan to do that in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks for already registered types were added in the precursor to ml_dtypes, when both JAX and tensorflow registered their own copies of bfloat16. Since that is no longer a concern, we can remove this logic.