Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Foriegn Key Only Fields #280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndwhelan
Copy link

When building the changes JSON for a LogEntry, following
relations (e.g. ForeigKey fields) can resutl in a
significant performance penalty. This commit adds support for
only logging to foreign key value, by specifying
fields to log in this manner wiht a fk_only_fields
when registering a model with the audit log.

When building the changes JSON for a LogEntry, following
relations (e.g. `ForeigKey` fields) can resutl in a
significant performance penalty. This commit adds support for
only logging to foreign key value, by specifying
fields to log in this manner wiht a `fk_only_fields`
when registering a model with the audit log.
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #280 into master will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   82.20%   82.49%   +0.28%     
==========================================
  Files          18       18              
  Lines         489      497       +8     
==========================================
+ Hits          402      410       +8     
  Misses         87       87              
Impacted Files Coverage Δ
auditlog/diff.py 88.23% <100.00%> (+1.13%) ⬆️
auditlog/registry.py 91.37% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31418d5...8975d57. Read the comment docs.

@aqeelat
Copy link
Member

aqeelat commented Dec 17, 2022

Thank you @ndwhelan for your PR. Can you please rebase it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants