Ignore null changeset on creation and deletion #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I registered a nullable field of a model using
include_fields
. There was a a check for nullchanges
in thelog_update
receiver, but not thelog_create
andlog_delete
ones. This meant that a log entry was created withnull
for the changes field whenever a model was created or updated, but didn't have a value for that field.When the mixin method
msg_short
is called in the Audit Log admin index, it would error because it's expecting an object for changes.What Changed:
log_create
andlog_delete
to make sure entries aren't created if the changes are None.