Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in serialized_data with F expressions #544

Merged

Conversation

hramezani
Copy link
Member

Closes #526

@hramezani hramezani force-pushed the model_serilization_f_expression branch from faafb71 to de13b83 Compare July 12, 2023 20:48
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #544 (de13b83) into master (0343846) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   94.34%   94.36%   +0.01%     
==========================================
  Files          30       30              
  Lines         902      905       +3     
==========================================
+ Hits          851      854       +3     
  Misses         51       51              
Impacted Files Coverage Δ
auditlog/models.py 89.76% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hramezani hramezani requested a review from peymanslh July 12, 2023 21:46
Copy link
Member

@peymanslh peymanslh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hramezani hramezani merged commit 9bcc511 into jazzband:master Jul 13, 2023
@hramezani hramezani deleted the model_serilization_f_expression branch July 13, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializing fields with F expressions doesn't work
2 participants