Improve auto model registration #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqeelat
force-pushed
the
improve_auto_model_registration
branch
from
efd8727
to
64e013f
Compare
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
+ Coverage 94.54% 94.56% +0.02%
==========================================
Files 30 30
Lines 898 902 +4
==========================================
+ Hits 849 853 +4
Misses 49 49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…n-managed ones feat: automatically register m2m fields for models when opting to auto register models
aqeelat
force-pushed
the
improve_auto_model_registration
branch
from
64e013f
to
71fce7a
Compare
hramezani
reviewed
Aug 5, 2023
| @@ -14,6 +14,7 @@ | |||
| - feat: Added pre-log and post-log signals. ([#483](https://github.com/jazzband/django-auditlog/pull/483)) | |||
| - feat: Make timestamp in LogEntry overwritable. ([#476](https://github.com/jazzband/django-auditlog/pull/476)) | |||
| - feat: Support excluding field names globally when ```AUDITLOG_INCLUDE_ALL_MODELS``` is enabled. ([#498](https://github.com/jazzband/django-auditlog/pull/498)) | |||
| - feat: Improved auto model registration to include auto-created models and exclude non-managed models, and automatically register m2m fields for models. ([#550](https://github.com/jazzband/django-auditlog/pull/550)) | |||
There was a problem hiding this comment.
Shouldn't it be in Breaking Changes section?
There was a problem hiding this comment.
why is this a breaking change?
|
@aqeelat Thanks for this PR. Only a question otherwise, LGTM |
hramezani
approved these changes
Aug 9, 2023
Why are we excluding non-managed models? Just because a model isn't managed doesn't mean we don't want to track changes to instances of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #315
closes #548
feat: collect all models including auto created ones and excluding non-managed ones
feat: automatically register m2m fields for models when opting to auto register models