Set history delete_related to False by default #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. The default behavior is to delete the related objects, but it doesn't make sense to apply it to audit log entries, at least not by default.
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 31 31
Lines 988 988
=======================================
Hits 938 938
Misses 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hramezani
approved these changes
Aug 24, 2023
|
Thanks @aleh-rymasheuski |
aleh-rymasheuski
added a commit
to MacmillanPlatform/django-auditlog
that referenced
this pull request
Sep 1, 2023
This is a breaking change. The default behavior is to delete the related objects, but it doesn't make sense to apply it to audit log entries, at least not by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #493 and my comment at #493 (comment), we should not delete audit log entries together with the tracked object by default.