Sync django query and postgres query #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s value for changes_text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 95.21% 95.29% +0.07%
==========================================
Files 31 31
Lines 1025 1041 +16
==========================================
+ Hits 976 992 +16
Misses 49 49 ☔ View full report in Codecov by Sentry. |
hramezani
approved these changes
Jun 12, 2024
|
Thanks @GreatBahram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade documentation recommends a multi-stage upgrade, during which some records might have a
changesfield that is no longer empty. This case is handled in the Django query but not in the Postgres one.Additionally, if there are many records and the upgrade fails, we are returned to the initial state, which is not ideal.
This change should take care of these problems 🤞