-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reintroduced inputfile.seek(0)
to utils.uncompress_file
#503
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 91.21% 91.13% -0.09%
==========================================
Files 19 19
Lines 854 857 +3
Branches 150 150
==========================================
+ Hits 779 781 +2
- Misses 40 41 +1
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Can you add a line item on the changelog, and a unit test (if feasible)? |
@Archmonger yes, sure. The changelog is docs/changelog.rst right? The newest main point is 4.0.0b0 (2021-12-19) should I just add it there? |
This change would belong in an On a side note, looks like there was a bit of forgetfulness of bumping the changelog from @johnthagen and I. I will retroactively add |
Changelog PR has been created: #504 |
Ok, i added a test and the edited the changelog. |
That's pretty minor so feel free to fold it into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged after resolving merge conflicts.
Description
This is a very small fix for #292.
I think this issue got introduced way back by #189.
In there line 244
inputfile.seek(0)
got removed, which seems to cause this issue.Simply reintroducing this line makes the uncompressing work again.
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).