Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better example HTML in docs for previous/first buttons #252

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

spookylukey
Copy link
Contributor

@spookylukey spookylukey commented Nov 24, 2023

When going to a previous form, we don't want the user to get stuck on an invalid form. The formnovalidate attribute is what we need. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/submit#formnovalidate

When going to a previous form, we don't want the user to get stuck on an invalid form. The formnovlidate attribute is what we need. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/submit#formnovalidate
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b73094c) 93.83% compared to head (7080929) 93.83%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          11       11           
  Lines         535      535           
  Branches       87       87           
=======================================
  Hits          502      502           
  Misses         21       21           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@claudep claudep merged commit a4db7c5 into jazzband:master Nov 24, 2023
8 checks passed
@spookylukey spookylukey deleted the patch-1 branch November 24, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants