Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django-upgrade to our pre-commit checks #169

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

ticosax
Copy link
Member

@ticosax ticosax commented Mar 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #169 (11715e2) into master (d29ed3f) will increase coverage by 1.83%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   95.45%   97.28%   +1.83%     
==========================================
  Files          24       24              
  Lines         528      516      -12     
==========================================
- Hits          504      502       -2     
+ Misses         24       14      -10     
Impacted Files Coverage Δ
django_fsm_log/backends.py 81.03% <0.00%> (+5.22%) ⬆️
tests/admin.py 100.00% <100.00%> (ø)
tests/test_admin.py 100.00% <100.00%> (+16.66%) ⬆️
tests/urls.py 100.00% <100.00%> (+50.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ticosax
Copy link
Member Author

ticosax commented Mar 24, 2023

I will rebase it after #168

@ticosax ticosax force-pushed the pre-commit-django-upgrade branch from d038b79 to 4a9e4f9 Compare March 24, 2023 09:42
@ticosax ticosax requested a review from MRigal March 24, 2023 09:46
tests/urls.py Outdated Show resolved Hide resolved
@ticosax ticosax force-pushed the pre-commit-django-upgrade branch from 887635f to eea70a9 Compare March 24, 2023 11:23
@ticosax ticosax requested a review from MRigal April 5, 2023 07:45
Copy link
Member

@MRigal MRigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ticosax ticosax merged commit d27ed8c into jazzband:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants