Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python3.7 and bring support for django3.12 #192

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ticosax
Copy link
Member

@ticosax ticosax commented Jun 21, 2024

Also test against django releases 4.2 & 5.0
And change dependency to django-fsm-2 a maintained fork of django-fsm.

@ticosax
Copy link
Member Author

ticosax commented Jun 21, 2024

@pfouque are you okay with this change ?

@ticosax ticosax requested a review from lorenzomorandini June 21, 2024 10:49
@pfouque
Copy link
Member

pfouque commented Jun 21, 2024

@pfouque are you okay with this change ?

Definitely!

NB: The repository will probably be transferred to django-commons at some point, but it will be transferred with access to the PyPI project!

Copy link
Member

@pfouque pfouque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

tox.ini Outdated Show resolved Hide resolved
@ticosax
Copy link
Member Author

ticosax commented Jun 21, 2024

image
merging is blocked by this requirement. But I don't know how to disable it.
Any advice ?

@lorenzomorandini
Copy link
Contributor

@pfouque
Copy link
Member

pfouque commented Jun 21, 2024

You could try pushing an empty commit to force a new run of those checks ... It may work :)

@ticosax
Copy link
Member Author

ticosax commented Jun 24, 2024

@ticosax do you have access to the settings of the repo? I don't but this could be it https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule#deleting-a-branch-protection-rule

unfortunately I don't have access to the settings. @MRigal maybe yourself ?

@ticosax
Copy link
Member Author

ticosax commented Jun 24, 2024

You could try pushing an empty commit to force a new run of those checks ... It may work :)

I rebased the branch and it's still the same. Apparently like @lorenzomorandini suggested, it is a branch protection rule.
We will have to call for help with one of the roadies I guess?

Also test against django releases 4.2 & 5.0
@jezdez
Copy link
Member

jezdez commented Dec 9, 2024

This is now finally unblocked, also see my comment in jazzband/help#368

@ticosax ticosax merged commit 8be2264 into jazzband:master Dec 10, 2024
7 checks passed
@ticosax ticosax deleted the maintain branch December 10, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants